From 801edeccc6f529647eaed0dd23728a257cf9479f Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 7 Jan 2010 14:50:43 +0100 Subject: s3: Remove some code that has become unnecessary The code I just removed was checked in with e5466fffc286a99f as a bug fix for https://bugzilla.samba.org/show_bug.cgi?id=3319. With the changes to is_visible_file made with 9e8b8f8c16612 these lines have become unnecessary, even with "hide unreadable = yes" dead msdfs symlinks show. This is because we can not stat(2) them and default to showing them. Why this change? I have a user who wants to use "hide unreadable" on msdfs links. Because you can't edit acls on symlinks themselves, the user created the targets as bogus, empty files that just exist as acl placeholders. With the code in place that this patch removes, we never allow this to work. Jeremy, please check! :-) Thanks, Volker --- source3/smbd/dir.c | 8 -------- 1 file changed, 8 deletions(-) (limited to 'source3') diff --git a/source3/smbd/dir.c b/source3/smbd/dir.c index 5ce4a7b099..3fe3218762 100644 --- a/source3/smbd/dir.c +++ b/source3/smbd/dir.c @@ -1227,14 +1227,6 @@ bool is_visible_file(connection_struct *conn, const char *dir_path, goto out; } - /* If it's a dfs symlink, ignore _hide xxxx_ options */ - if (lp_host_msdfs() && - lp_msdfs_root(SNUM(conn)) && - is_msdfs_link(conn, entry, NULL)) { - ret = true; - goto out; - } - /* Create an smb_filename with stream_name == NULL. */ status = create_synthetic_smb_fname(talloc_tos(), entry, NULL, pst, &smb_fname_base); -- cgit