From c69c5c132ade57d1eb860ae8f73b0e48de0e5c6f Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 21 Mar 2008 10:40:40 +0100 Subject: Fix Coverity ID 547 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Günther, please check. If r->in.ads==NULL, we can't call ads_leave_realm at all. Thanks, Volker (This used to be commit 120d8c889fa9ad61c74f1f936e83537513454648) --- source3/libnet/libnet_join.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'source3') diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c index d3fba167d9..52376ac821 100644 --- a/source3/libnet/libnet_join.c +++ b/source3/libnet/libnet_join.c @@ -264,10 +264,7 @@ static ADS_STATUS libnet_unjoin_remove_machine_acct(TALLOC_CTX *mem_ctx, ADS_STATUS status; if (!r->in.ads) { - status = libnet_unjoin_connect_ads(mem_ctx, r); - if (!ADS_ERR_OK(status)) { - return status; - } + return libnet_unjoin_connect_ads(mem_ctx, r); } status = ads_leave_realm(r->in.ads, r->in.machine_name); -- cgit