From de2846012b8b0ca24d342304d88819cab9f2cecf Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox@samba.org>
Date: Wed, 29 Jul 2009 14:23:26 +0200
Subject: s3:dbwrap: don't leak in dbwrap_change_int32_atomic().

Michael
---
 source3/lib/dbwrap_util.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'source3')

diff --git a/source3/lib/dbwrap_util.c b/source3/lib/dbwrap_util.c
index b9b525a47b..1e3755af98 100644
--- a/source3/lib/dbwrap_util.c
+++ b/source3/lib/dbwrap_util.c
@@ -167,7 +167,8 @@ NTSTATUS dbwrap_change_int32_atomic(struct db_context *db, const char *keystr,
 		val = IVAL(rec->value.dptr, 0);
 		*oldval = val;
 	} else {
-		return NT_STATUS_UNSUCCESSFUL;
+		ret = NT_STATUS_UNSUCCESSFUL;
+		goto done;
 	}
 
 	val += change_val;
@@ -177,8 +178,8 @@ NTSTATUS dbwrap_change_int32_atomic(struct db_context *db, const char *keystr,
 
 	ret = rec->store(rec, data, TDB_REPLACE);
 
+done:
 	TALLOC_FREE(rec);
-
 	return ret;
 }
 
-- 
cgit