From fcdba1b36ffc3cfdeac71863f26a1605d3b24fa5 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 29 Apr 2010 12:11:04 +0200 Subject: s3: Fix an uninitialized variable in idmap_tdb2_sid_to_id() When we find an invalid record in the database, there's no point in checking the non-existing value against the range limits. --- source3/winbindd/idmap_tdb2.c | 1 + 1 file changed, 1 insertion(+) (limited to 'source3') diff --git a/source3/winbindd/idmap_tdb2.c b/source3/winbindd/idmap_tdb2.c index ec83cae8a3..3e2021457a 100644 --- a/source3/winbindd/idmap_tdb2.c +++ b/source3/winbindd/idmap_tdb2.c @@ -750,6 +750,7 @@ static NTSTATUS idmap_tdb2_sid_to_id(struct idmap_tdb2_context *ctx, struct id_m } else { /* Unknown record type ! */ DEBUG(2, ("Found INVALID record %s -> %s\n", keystr, (const char *)data.dptr)); ret = NT_STATUS_INTERNAL_DB_ERROR; + goto done; } /* apply filters before returning result */ -- cgit