From 18f0e24f5573611c983d2d5d37409fa77b199dd5 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 3 Mar 2010 11:34:04 +1100 Subject: s4:credentials talloc_free() any previous salt_principal This isn't used often, but it is generally better not to leak it onto what may be a longer-term context. Andrew Bartlett --- source4/auth/credentials/credentials.h | 2 +- source4/auth/credentials/credentials_krb5.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'source4/auth') diff --git a/source4/auth/credentials/credentials.h b/source4/auth/credentials/credentials.h index 6c077c9bec..33de8341c7 100644 --- a/source4/auth/credentials/credentials.h +++ b/source4/auth/credentials/credentials.h @@ -76,7 +76,7 @@ struct cli_credentials { const char *domain; const char *realm; const char *principal; - const char *salt_principal; + char *salt_principal; const char *bind_dn; diff --git a/source4/auth/credentials/credentials_krb5.c b/source4/auth/credentials/credentials_krb5.c index e04b7f5926..d8ce0e58e2 100644 --- a/source4/auth/credentials/credentials_krb5.c +++ b/source4/auth/credentials/credentials_krb5.c @@ -798,6 +798,7 @@ const char *cli_credentials_get_salt_principal(struct cli_credentials *cred) _PUBLIC_ void cli_credentials_set_salt_principal(struct cli_credentials *cred, const char *principal) { + talloc_free(cred->salt_principal); cred->salt_principal = talloc_strdup(cred, principal); } -- cgit