From 6582d4739c25a879c58fc768290b3f97ecf795c7 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sun, 14 Nov 2010 13:40:02 +1100 Subject: s4-auth: fixed crash in krb5 auth remote_addr was used after free --- source4/auth/kerberos/krb5_init_context.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'source4/auth') diff --git a/source4/auth/kerberos/krb5_init_context.c b/source4/auth/kerberos/krb5_init_context.c index 6727de0f99..ebe19e6b25 100644 --- a/source4/auth/kerberos/krb5_init_context.c +++ b/source4/auth/kerberos/krb5_init_context.c @@ -207,7 +207,6 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context, { krb5_error_code ret; NTSTATUS status; - struct socket_address *remote_addr; const char *name; struct addrinfo *ai, *a; struct smb_krb5_socket *smb_krb5; @@ -240,6 +239,7 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context, } for (a = ai; a; a = ai->ai_next) { + struct socket_address *remote_addr; smb_krb5 = talloc(tmp_ctx, struct smb_krb5_socket); if (!smb_krb5) { talloc_free(tmp_ctx); @@ -291,7 +291,6 @@ krb5_error_code smb_krb5_send_and_recv_func(krb5_context context, talloc_free(smb_krb5); continue; } - talloc_free(remote_addr); /* Setup the FDE, start listening for read events * from the start (otherwise we may miss a socket -- cgit