From 8631a9090bd22f5ce3036dd596a213dd9d8a67c4 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 13 Dec 2012 14:11:29 +0100 Subject: s4-client: Check return codes in do_connect(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source4/client/client.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) (limited to 'source4/client') diff --git a/source4/client/client.c b/source4/client/client.c index 1cd0e5d063..9985338477 100644 --- a/source4/client/client.c +++ b/source4/client/client.c @@ -3133,14 +3133,30 @@ static bool do_connect(struct smbclient_context *ctx, if (strncmp(specified_share, "\\\\", 2) == 0 || strncmp(specified_share, "//", 2) == 0) { - smbcli_parse_unc(specified_share, ctx, &server, &share); + bool ok; + + ok = smbcli_parse_unc(specified_share, ctx, &server, &share); + if (!ok) { + d_printf("Failed to parse UNC\n"); + talloc_free(ctx); + return false; + } } else { share = talloc_strdup(ctx, specified_share); server = talloc_strdup(ctx, specified_server); + if (share == NULL || server == NULL) { + d_printf("Failed to allocate memory for server and share\n"); + talloc_free(ctx); + return false; + } } ctx->remote_cur_dir = talloc_strdup(ctx, "\\"); - + if (ctx->remote_cur_dir == NULL) { + talloc_free(ctx); + return false; + } + status = smbcli_full_connection(ctx, &ctx->cli, server, ports, share, NULL, socket_options, -- cgit