From f10c63810077a6759a9df4e9c653066f9f355d96 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 30 Apr 2012 15:44:01 +1000 Subject: s4-messaging: Fill in the whole server_id in all use cases This started per https://bugzilla.samba.org/show_bug.cgi?id=8872#c4 and avoids any possible collision with a different process. We also need to ensure that across a Samba installation on a single node that id.vnn is the same. Samba4 previously used 0, while Samba3 used NONCLUSTER_VNN. When a message is sent between these 'different' nodes, the error NT_STATUS_INVALID_DEVICE_REQUEST is raised. Andrew Bartlett --- source4/cluster/local.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'source4/cluster') diff --git a/source4/cluster/local.c b/source4/cluster/local.c index 24cbe81c48..df67bcfa79 100644 --- a/source4/cluster/local.c +++ b/source4/cluster/local.c @@ -37,6 +37,9 @@ static struct server_id local_id(struct cluster_ops *ops, uint64_t pid, uint32_t ZERO_STRUCT(server_id); server_id.pid = pid; server_id.task_id = task_id; + server_id.vnn = NONCLUSTER_VNN; + /* This is because we are not in the s3 serverid database */ + server_id.unique_id = SERVERID_UNIQUE_ID_NOT_TO_VERIFY; return server_id; } -- cgit