From feb00fe7cc238a78b3832c116cb4634936597735 Mon Sep 17 00:00:00 2001
From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Wed, 10 Nov 2010 16:05:16 +0100
Subject: s4:dsdb - proof against empty RDN values where expected

This should prevent crashes as pointed out on the mailing list.
---
 source4/dsdb/common/util.c | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'source4/dsdb/common/util.c')

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 04d97043b2..7f6ce64180 100644
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -1595,7 +1595,12 @@ int samdb_find_site_for_computer(struct ldb_context *ldb,
 		talloc_free(dn);
 		return LDB_ERR_INVALID_DN_SYNTAX;
 	}
+
 	rdn_val = ldb_dn_get_rdn_val(dn);
+	if (rdn_val == NULL) {
+		return LDB_ERR_OPERATIONS_ERROR;
+	}
+
 	(*site_name) = talloc_strndup(mem_ctx, (const char *)rdn_val->data, rdn_val->length);
 	talloc_free(dn);
 	if (!*site_name) {
-- 
cgit