From 5896b7299331aedd065397d2078c62d85bcf68f6 Mon Sep 17 00:00:00 2001 From: Matthias Dieter Wallnöfer Date: Wed, 2 Mar 2011 18:50:11 +0100 Subject: s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid ERR_INVALID_DN_SYNTAX fits better than ERR_OPERATION_ERROR in this case. This one gets triggered if we perform "add" requests without the LDAP server. Reviewed by: Tridge --- source4/dsdb/samdb/ldb_modules/objectclass.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'source4/dsdb/samdb') diff --git a/source4/dsdb/samdb/ldb_modules/objectclass.c b/source4/dsdb/samdb/ldb_modules/objectclass.c index f48917c5fd..817f50a964 100644 --- a/source4/dsdb/samdb/ldb_modules/objectclass.c +++ b/source4/dsdb/samdb/ldb_modules/objectclass.c @@ -421,7 +421,9 @@ static int objectclass_add(struct ldb_module *module, struct ldb_request *req) /* get copy of parent DN */ parent_dn = ldb_dn_get_parent(ac, ac->req->op.add.message->dn); if (parent_dn == NULL) { - return ldb_operr(ldb); + /* the DN itself might be wrong - therefore + * "ERR_INVALID_DN_SYNTAX" fits better here. */ + return LDB_ERR_INVALID_DN_SYNTAX; } ret = ldb_build_search_req(&search_req, ldb, -- cgit