From de318e58b01696e7aea39d14da099dbb4173c055 Mon Sep 17 00:00:00 2001
From: Andrew Tridgell <tridge@samba.org>
Date: Wed, 7 Sep 2011 16:25:48 +1000
Subject: s4-dsdb: prevent crash on bad DN in construct_parent_guid()

this was found by a flakey test in autobuild
---
 source4/dsdb/samdb/ldb_modules/operational.c | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'source4/dsdb')

diff --git a/source4/dsdb/samdb/ldb_modules/operational.c b/source4/dsdb/samdb/ldb_modules/operational.c
index dcc047f13e..1a13895a93 100644
--- a/source4/dsdb/samdb/ldb_modules/operational.c
+++ b/source4/dsdb/samdb/ldb_modules/operational.c
@@ -283,6 +283,9 @@ static int construct_parent_guid(struct ldb_module *module,
 	ret = dsdb_module_search_dn(module, msg, &res, msg->dn, attrs,
 	                            DSDB_FLAG_NEXT_MODULE |
 	                            DSDB_SEARCH_SHOW_RECYCLED, parent);
+	if (ret != LDB_SUCCESS) {
+		return ret;
+	}
 
 	instanceType = ldb_msg_find_attr_as_uint(res->msgs[0],
 						 "instanceType", 0);
-- 
cgit