From 655b710204e7a7d8e486da7ba675fcbeed116fea Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 16 Sep 2006 16:59:37 +0000 Subject: r18584: found one of the fd leaks. The registry backend was using a talloc(NULL, xxx) to allocate the registry context. That had two consequences 1) it was a massive memory leak, as all winreg operations leaked their entire context (including an open ldb database) every time 2) event_context_find() never found the exsting event context, so we used a new event context each time, which called epoll_create() each time, which caused a fd to be allocated (This used to be commit 1c0a3de39828b43149d8981fc7f10e7c8b59a392) --- source4/gtk/tools/gregedit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source4/gtk') diff --git a/source4/gtk/tools/gregedit.c b/source4/gtk/tools/gregedit.c index e0717187d9..cf03eebec8 100644 --- a/source4/gtk/tools/gregedit.c +++ b/source4/gtk/tools/gregedit.c @@ -385,7 +385,7 @@ static void on_open_gconf_activate(GtkMenuItem *menuitem, gpointer user_data) static void on_open_local_activate(GtkMenuItem *menuitem, gpointer user_data) { - WERROR error = reg_open_local(®istry, NULL, NULL); + WERROR error = reg_open_local(NULL, ®istry, NULL, NULL); if(!W_ERROR_IS_OK(error)) { gtk_show_werror(mainwin, "Error while opening local registry", error); return; @@ -953,7 +953,7 @@ static GtkWidget* create_savefilewin (void) static int gregedit_load_defaults(void) { - WERROR error = reg_open_local(®istry, NULL, NULL); + WERROR error = reg_open_local(NULL, ®istry, NULL, NULL); if(!W_ERROR_IS_OK(error)) { gtk_show_werror(mainwin, "Error while loading local registry", error); return -1; -- cgit