From f9c7357d74d2c76cfb4046cb05e9533a0cb22303 Mon Sep 17 00:00:00 2001 From: Steve French Date: Mon, 15 Aug 2005 23:52:15 +0000 Subject: r9310: Add two missing return statements after null pointer checks to fix potential oops in kdc code. Found by coverity. (This used to be commit 3b707b928969c87ac7e9948a567a3ebbc754f28c) --- source4/kdc/hdb-ldb.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'source4/kdc') diff --git a/source4/kdc/hdb-ldb.c b/source4/kdc/hdb-ldb.c index 651aa2347a..0aa18423a0 100644 --- a/source4/kdc/hdb-ldb.c +++ b/source4/kdc/hdb-ldb.c @@ -644,6 +644,7 @@ static krb5_error_code LDB_lookup_spn_alias(krb5_context context, struct ldb_con if (!spnmappings || spnmappings->num_values == 0) { krb5_warnx(context, "ldb_search: dn: %s no sPNMappings attribute", service_dn); krb5_set_error_string(context, "ldb_search: dn: %s no sPNMappings attribute", service_dn); + return HDB_ERR_NOENTRY; } for (i = 0; i < spnmappings->num_values; i++) { @@ -664,6 +665,7 @@ static krb5_error_code LDB_lookup_spn_alias(krb5_context context, struct ldb_con service_dn, mapping); krb5_set_error_string(context, "ldb_search: dn: %s sPNMapping malformed: %s", service_dn, mapping); + return HDB_ERR_NOENTRY; } p[0] = '\0'; p++; -- cgit