From 79f7b58630e996ec734acb10e1fb99991979fe1b Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 25 Jul 2006 07:48:23 +0000 Subject: r17226: add some comments about ldap binds and pending requests metze (This used to be commit e8db1fb55833ab7b9e0be391ff822b34682cb38c) --- source4/ldap_server/ldap_bind.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'source4/ldap_server/ldap_bind.c') diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c index daa82c1e48..0e7a147e52 100644 --- a/source4/ldap_server/ldap_bind.c +++ b/source4/ldap_server/ldap_bind.c @@ -125,6 +125,12 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call) conn = call->conn; + /* + * TODO: a SASL bind with a different mechanism + * should cancel an inprogress SASL bind. + * (see RFC 4513) + */ + if (!conn->gensec) { conn->session_info = NULL; @@ -268,6 +274,14 @@ NTSTATUS ldapsrv_BindRequest(struct ldapsrv_call *call) struct ldapsrv_reply *reply; struct ldap_BindResponse *resp; + /* + * TODO: we should fail the bind request + * if there're any pending requests. + * + * also a simple bind should cancel an + * inprogress SASL bind. + * (see RFC 4513) + */ switch (req->mechanism) { case LDAP_AUTH_MECH_SIMPLE: return ldapsrv_BindSimple(call); -- cgit