From f5c5fd9e828b3e0bf6c2cdcd448c66fa1c8d41c1 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Wed, 1 Dec 2010 23:54:38 +1100 Subject: s4-ldap: removed an incorrect talloc_move() the parent of this session_info is either the stream_connection, or its a system_session(). In either case reparenting it on the ldapsrv_connection doesn't achieve anything that I can see. The move was causing a steal on reference error because the session_info often has multiple references. Thanks to Metze for spotting this. Autobuild-User: Andrew Tridgell Autobuild-Date: Wed Dec 1 22:10:42 CET 2010 on sn-devel-104 --- source4/ldap_server/ldap_server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source4/ldap_server') diff --git a/source4/ldap_server/ldap_server.c b/source4/ldap_server/ldap_server.c index 67fe18330f..db775c9a12 100644 --- a/source4/ldap_server/ldap_server.c +++ b/source4/ldap_server/ldap_server.c @@ -330,7 +330,7 @@ static void ldapsrv_accept(struct stream_connection *c, } conn->server_credentials = server_credentials; - conn->session_info = talloc_move(conn, &session_info); + conn->session_info = session_info; if (!NT_STATUS_IS_OK(ldapsrv_backend_Init(conn))) { ldapsrv_terminate_connection(conn, "backend Init failed"); -- cgit