From 2daf2897d5c70c0efbeba9b827c62700b9a9537c Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sat, 14 Jun 2008 13:00:53 -0400 Subject: Use a custom init function for samba4 that sets a samba4 specific debug function. By default do not debug, this is the most appropriate action for a library as we cannot assume what stderr is use for in the main app. The main app is responsible to set ev_debug_stderr if they so desire. (This used to be commit e566a2f308ac6fb4b526a744f7059b565670aea5) --- source4/lib/events/events_debug.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'source4/lib/events/events_debug.c') diff --git a/source4/lib/events/events_debug.c b/source4/lib/events/events_debug.c index 70b85d47e4..233844f024 100644 --- a/source4/lib/events/events_debug.c +++ b/source4/lib/events/events_debug.c @@ -43,9 +43,9 @@ int ev_set_debug(struct event_context *ev, /* debug function for ev_set_debug_stderr */ -static void ev_debug_stderr(void *context, enum ev_debug_level level, +void ev_debug_stderr(void *context, enum ev_debug_level level, const char *fmt, va_list ap) PRINTF_ATTRIBUTE(3,0); -static void ev_debug_stderr(void *context, enum ev_debug_level level, +void ev_debug_stderr(void *context, enum ev_debug_level level, const char *fmt, va_list ap) { if (level <= EV_DEBUG_WARNING) { @@ -63,13 +63,18 @@ int ev_set_debug_stderr(struct event_context *ev) } /* - log a message + * log a message + * + * The default debug action is to ignore debugging messages. + * This is the most appropriate action for a library. + * Applications using the library must decide where to + * redirect debugging messages */ void ev_debug(struct event_context *ev, enum ev_debug_level level, const char *fmt, ...) { va_list ap; if (ev->debug_ops.debug == NULL) { - ev_set_debug_stderr(ev); + return; } va_start(ap, fmt); ev->debug_ops.debug(ev->debug_ops.context, level, fmt, ap); -- cgit