From 8f9e87d858ae1cf2209cfd8332ad54a750252e24 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Mon, 4 Jul 2005 15:06:05 +0000 Subject: r8146: fix compiler warning metze (This used to be commit 5fcaa21d67e399aab4af15f4f6f919203c1152e5) --- source4/lib/ldb/common/ldb_dn.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'source4/lib/ldb/common') diff --git a/source4/lib/ldb/common/ldb_dn.c b/source4/lib/ldb/common/ldb_dn.c index 7556a144e2..1eaf4c486b 100644 --- a/source4/lib/ldb/common/ldb_dn.c +++ b/source4/lib/ldb/common/ldb_dn.c @@ -361,22 +361,20 @@ failed: char *ldb_dn_linearize(void *mem_ctx, const struct ldb_dn *edn) { char *dn, *value; - const char *format = "%s=%s"; int i; dn = talloc_strdup(mem_ctx, ""); LDB_DN_NULL_FAILED(dn); for (i = 0; i < edn->comp_num; i++) { - - if (i != 0) { - format = ",%s=%s"; - } - value = ldb_dn_escape_value(dn, edn->components[i].value); LDB_DN_NULL_FAILED(value); - dn = talloc_asprintf_append(dn, format, edn->components[i].name, value); + if (i == 0) { + dn = talloc_asprintf_append(dn, "%s=%s", edn->components[i].name, value); + } else { + dn = talloc_asprintf_append(dn, ",%s=%s", edn->components[i].name, value); + } LDB_DN_NULL_FAILED(dn); talloc_free(value); -- cgit