From e50c9826794f4a80b7200712afacb0752ccf8d6f Mon Sep 17 00:00:00 2001 From: Matthias Dieter Wallnöfer Date: Fri, 6 Nov 2009 18:35:17 +0100 Subject: LDB:NSS - make LDB "signed-safe" on counter variables "i" needs to be unsigned on both places since it counts till a "count" variable of a "struct ldb_result" object which itself is unsigned. I see counting variables much better as "unsigned" since in most cases we don't use negative values at all. We've only to be careful on binary searches and downto counts regarding them. --- source4/lib/ldb/nssldb/ldb-nss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source4/lib/ldb/nssldb/ldb-nss.c') diff --git a/source4/lib/ldb/nssldb/ldb-nss.c b/source4/lib/ldb/nssldb/ldb-nss.c index 8f7321031b..92b0635561 100644 --- a/source4/lib/ldb/nssldb/ldb-nss.c +++ b/source4/lib/ldb/nssldb/ldb-nss.c @@ -191,7 +191,7 @@ NSS_STATUS _ldb_nss_fill_group(struct group *result, size_t len; size_t bufpos; size_t lsize; - int i; + unsigned int i; bufpos = 0; @@ -280,7 +280,7 @@ NSS_STATUS _ldb_nss_fill_initgr(gid_t group, struct ldb_result *grlist) { NSS_STATUS ret; - int i; + unsigned int i; for (i = 0; i < grlist->count; i++) { -- cgit