From 4bb0cb7449960620052cd555854e59d8d8a9babe Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 19 Apr 2007 13:30:07 +0000 Subject: r22371: readd discard_const() to lib/util/util.h metze (This used to be commit 76fbe90596f5f26c09185129d9a4f3e2b42428e1) --- source4/lib/util/util.h | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'source4/lib/util') diff --git a/source4/lib/util/util.h b/source4/lib/util/util.h index f2531aaa85..8fde661cb7 100644 --- a/source4/lib/util/util.h +++ b/source4/lib/util/util.h @@ -41,6 +41,33 @@ extern const char *panic_action; #include "util/byteorder.h" #include "lib/util/util_proto.h" +/** + this is a warning hack. The idea is to use this everywhere that we + get the "discarding const" warning from gcc. That doesn't actually + fix the problem of course, but it means that when we do get to + cleaning them up we can do it by searching the code for + discard_const. + + It also means that other error types aren't as swamped by the noise + of hundreds of const warnings, so we are more likely to notice when + we get new errors. + + Please only add more uses of this macro when you find it + _really_ hard to fix const warnings. Our aim is to eventually use + this function in only a very few places. + + Also, please call this via the discard_const_p() macro interface, as that + makes the return type safe. +*/ +#ifndef discard_const +#define discard_const(ptr) ((void *)((intptr_t)(ptr))) +#endif + +/** Type-safe version of discard_const */ +#ifndef discard_const_p +#define discard_const_p(type, ptr) ((type *)discard_const(ptr)) +#endif + /** * assert macros */ -- cgit