From a109ee71fb9b8fa25f9ca739caaba5a1399b7864 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Thu, 22 Oct 2009 12:45:48 +1100 Subject: s4-ldb: added a TODO about checking the indexlist --- source4/lib/ldb/ldb_tdb/ldb_index.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'source4/lib') diff --git a/source4/lib/ldb/ldb_tdb/ldb_index.c b/source4/lib/ldb/ldb_tdb/ldb_index.c index 04c3c7acce..0d560fea5e 100644 --- a/source4/lib/ldb/ldb_tdb/ldb_index.c +++ b/source4/lib/ldb/ldb_tdb/ldb_index.c @@ -428,6 +428,8 @@ static bool ltdb_is_indexed(const struct ldb_message *index_list, const char *at if (el == NULL) { return false; } + + /* TODO: this is too expensive! At least use a binary search */ for (i=0; inum_values; i++) { if (ldb_attr_cmp((char *)el->values[i].data, attr) == 0) { return true; -- cgit