From f1ec8da56dd106481b9d79f5d590ee6ba26f7a4b Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 13 Nov 2007 04:31:28 +0100 Subject: r25933: LDB: Don't free errstring until after the printf, in case it is one of the arguments. Andrew Bartlett (This used to be commit af40b1cd88f0e932665f6fe90daae8e687a3dc0c) --- source4/lib/ldb/common/ldb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'source4/lib') diff --git a/source4/lib/ldb/common/ldb.c b/source4/lib/ldb/common/ldb.c index 25d273f8e9..f687e152d3 100644 --- a/source4/lib/ldb/common/ldb.c +++ b/source4/lib/ldb/common/ldb.c @@ -277,14 +277,16 @@ void ldb_set_errstring(struct ldb_context *ldb, const char *err_string) void ldb_asprintf_errstring(struct ldb_context *ldb, const char *format, ...) { va_list ap; + char *old_string = NULL; if (ldb->err_string) { - talloc_free(ldb->err_string); + old_string = ldb->err_string; } va_start(ap, format); ldb->err_string = talloc_vasprintf(ldb, format, ap); va_end(ap); + talloc_free(old_string); } void ldb_reset_err_string(struct ldb_context *ldb) -- cgit