From f8391489bfbeea20e450b9ec7640c3e04c713ced Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Fri, 18 Nov 2005 23:27:58 +0000 Subject: r11794: - fixed a valgrind error in libnet, caused by using a stack variable after the function has returned (the *address variable was assigned into the state). - changed libnet to use event_context_find() instead of event_context_init(), so it works as a child of existing code that uses a event context (This used to be commit 47ceb2d3558304b4c4fb00582fb25a885cea2ef5) --- source4/libnet/libnet_rpc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'source4/libnet/libnet_rpc.c') diff --git a/source4/libnet/libnet_rpc.c b/source4/libnet/libnet_rpc.c index 7b07cedeac..9917b17255 100644 --- a/source4/libnet/libnet_rpc.c +++ b/source4/libnet/libnet_rpc.c @@ -77,11 +77,10 @@ static NTSTATUS libnet_RpcConnectPdc(struct libnet_context *ctx, TALLOC_CTX *mem NTSTATUS status; struct libnet_RpcConnect r2; struct libnet_Lookup f; - const char *address = talloc_array(ctx, const char, 16); f.in.hostname = r->in.domain_name; f.in.methods = NULL; - f.out.address = &address; + f.out.address = NULL; status = libnet_LookupPdc(ctx, mem_ctx, &f); if (!NT_STATUS_IS_OK(status)) { @@ -91,7 +90,7 @@ static NTSTATUS libnet_RpcConnectPdc(struct libnet_context *ctx, TALLOC_CTX *mem } r2.level = LIBNET_RPC_CONNECT_SERVER; - r2.in.domain_name = talloc_strdup(mem_ctx, *f.out.address); + r2.in.domain_name = talloc_strdup(mem_ctx, f.out.address[0]); r2.in.dcerpc_iface_name = r->in.dcerpc_iface_name; r2.in.dcerpc_iface_uuid = r->in.dcerpc_iface_uuid; r2.in.dcerpc_iface_version = r->in.dcerpc_iface_version; -- cgit