From 5960b7b2a44161dba5dc96e6973e1fcc92b14bdd Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 23 Apr 2012 17:28:39 +1000 Subject: s4-libnet Always return after composite_error() These instances should not cause a problem, but make it easier to audit for this kind of problem in the future with grep. Andrew Bartlett Autobuild-User: Andrew Bartlett Autobuild-Date: Mon Apr 23 14:29:45 CEST 2012 on sn-devel-104 --- source4/libnet/libnet_group.c | 3 ++- source4/libnet/libnet_user.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'source4/libnet') diff --git a/source4/libnet/libnet_group.c b/source4/libnet/libnet_group.c index b12037e1f3..928ce69225 100644 --- a/source4/libnet/libnet_group.c +++ b/source4/libnet/libnet_group.c @@ -680,10 +680,11 @@ static void continue_groups_enumerated(struct tevent_req *subreq) /* that's it */ composite_done(c); - + return; } else { /* something went wrong */ composite_error(c, c->status); + return; } } diff --git a/source4/libnet/libnet_user.c b/source4/libnet/libnet_user.c index e56ed498c2..dc0691ac22 100644 --- a/source4/libnet/libnet_user.c +++ b/source4/libnet/libnet_user.c @@ -1146,10 +1146,12 @@ static void continue_users_enumerated(struct tevent_req *subreq) /* that's it */ composite_done(c); + return; } else { /* something went wrong */ composite_error(c, c->status); + return; } } -- cgit