From af18339e037e388ddac4a417544c295bcc44b31d Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 6 Dec 2012 15:11:09 +0100 Subject: s4-libnet: Don't call talloc_get_type() for the same struct twice. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source4/libnet/libnet_rpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source4/libnet') diff --git a/source4/libnet/libnet_rpc.c b/source4/libnet/libnet_rpc.c index 349e1f8664..13115288b1 100644 --- a/source4/libnet/libnet_rpc.c +++ b/source4/libnet/libnet_rpc.c @@ -189,11 +189,11 @@ static NTSTATUS libnet_RpcConnectSrv_recv(struct composite_context *c, struct libnet_RpcConnect *r) { NTSTATUS status; - struct rpc_connect_srv_state *s = talloc_get_type(c->private_data, - struct rpc_connect_srv_state); status = composite_wait(c); if (NT_STATUS_IS_OK(status)) { + struct rpc_connect_srv_state *s; + /* move the returned rpc pipe between memory contexts */ s = talloc_get_type(c->private_data, struct rpc_connect_srv_state); r->out.dcerpc_pipe = talloc_steal(mem_ctx, s->r.out.dcerpc_pipe); -- cgit