From 42c4dd18322452b6ab709eac8ba6724daf93ed36 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Thu, 28 Oct 2004 23:09:40 +0000 Subject: r3341: - don't zero the async structure (makes valgrind more useful) - get rid of req->mid, as it isn't a safe value to use to match requests in the server (it is safe in the client code, as we choose the mid, but in the server we can't rely on other clients to choose the mid carefully) (This used to be commit 938fb44351e12a515073ea94cd306988d5ca7340) --- source4/smb_server/request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source4/smb_server/request.c') diff --git a/source4/smb_server/request.c b/source4/smb_server/request.c index 34273a63a8..5b137b4c53 100644 --- a/source4/smb_server/request.c +++ b/source4/smb_server/request.c @@ -57,10 +57,10 @@ struct smbsrv_request *init_smb_request(struct smbsrv_connection *smb_conn) req->async_states = talloc_p(req, struct ntvfs_async_state); if (!req->async_states) { + talloc_free(req); return NULL; } - - ZERO_STRUCTP(req->async_states); + req->async_states->state = 0; return req; } -- cgit