From 00e772d747ca9c28961c11bc2ed10cd800c6b0d9 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 22 May 2006 06:17:10 +0000 Subject: r15796: this talloc_reference() was causing a memory leak on every NTVFS request. The problem is that the talloc_free() in smbsrv_send_reply_nosign() frees this reference, but doesn't free the memory iself, thus leaving it attached to the connection context. Metze, what was the idea behind this reference? If we need it, then we need a corresponding talloc_free() to go with it. (This used to be commit 2e105a32c78384b16a0e6a6dc8ff504593afef2e) --- source4/smb_server/smb_server.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'source4/smb_server/smb_server.h') diff --git a/source4/smb_server/smb_server.h b/source4/smb_server/smb_server.h index 0389d79306..de5774a930 100644 --- a/source4/smb_server/smb_server.h +++ b/source4/smb_server/smb_server.h @@ -421,10 +421,6 @@ struct smbsrv_connection { smbsrv_send_error(req, NT_STATUS_NO_MEMORY); \ return; \ } \ - if (!talloc_reference(req->ntvfs, req)) { \ - smbsrv_send_error(req, NT_STATUS_NO_MEMORY); \ - return; \ - } \ req->ntvfs->frontend_data.private_data = req; \ } while (0) -- cgit