From 700f4649511dbef417e639509d2f3374b5c8c6f3 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 13 Feb 2010 13:01:08 +1100 Subject: s4-torture: use TYPESAFE_QSORT() in smbtorture --- source4/torture/raw/streams.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'source4/torture/raw/streams.c') diff --git a/source4/torture/raw/streams.c b/source4/torture/raw/streams.c index a55575b6a3..5d4167dbd3 100644 --- a/source4/torture/raw/streams.c +++ b/source4/torture/raw/streams.c @@ -26,6 +26,7 @@ #include "system/filesys.h" #include "libcli/libcli.h" #include "torture/util.h" +#include "lib/util/tsort.h" #define BASEDIR "\\teststreams" @@ -106,17 +107,13 @@ static bool check_stream(struct smbcli_state *cli, const char *location, return true; } -static int qsort_string(const void *v1, const void *v2) +static int qsort_string(char * const *s1, char * const *s2) { - char * const *s1 = (char * const *)v1; - char * const *s2 = (char * const *)v2; return strcmp(*s1, *s2); } -static int qsort_stream(const void *v1, const void *v2) +static int qsort_stream(const struct stream_struct *s1, const struct stream_struct *s2) { - const struct stream_struct * s1 = (const struct stream_struct *)v1; - const struct stream_struct * s2 = (const struct stream_struct *)v2; return strcmp(s1->stream_name.s, s2->stream_name.s); } @@ -152,7 +149,7 @@ static bool check_stream_list(struct torture_context *tctx, goto done; } - qsort(exp_sort, num_exp, sizeof(*exp_sort), qsort_string); + TYPESAFE_QSORT(exp_sort, num_exp, qsort_string); stream_sort = (struct stream_struct *)talloc_memdup(tmp_ctx, finfo.stream_info.out.streams, @@ -163,8 +160,7 @@ static bool check_stream_list(struct torture_context *tctx, goto done; } - qsort(stream_sort, finfo.stream_info.out.num_streams, - sizeof(*stream_sort), qsort_stream); + TYPESAFE_QSORT(stream_sort, finfo.stream_info.out.num_streams, qsort_stream); for (i=0; i