From 60fd088c480e474c3db8870f1288462a8452cea3 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 26 Feb 2007 05:37:19 +0000 Subject: r21535: - fixed a crash in the RAW-ACLS test. When a dcerpc_pipe is created using the pattern in the clilsa code, it didn't fill in the p->binding structure. This affects nearly all users of dcerpc_pipe_open_smb(), so the simplest fix is to ensure that dcerpc_pipe_open_smb() initialises the binding if its not already there. - re-enable the RAW-ACLS test (This used to be commit d8875c286d2be49c01703d8fd58bbc1842054bd9) --- source4/torture/rpc/samba3rpc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'source4/torture/rpc') diff --git a/source4/torture/rpc/samba3rpc.c b/source4/torture/rpc/samba3rpc.c index c6be028a92..096aecea0b 100644 --- a/source4/torture/rpc/samba3rpc.c +++ b/source4/torture/rpc/samba3rpc.c @@ -107,7 +107,7 @@ BOOL torture_bind_authcontext(struct torture_context *torture) goto done; } - status = dcerpc_pipe_open_smb(lsa_pipe->conn, cli->tree, "\\lsarpc"); + status = dcerpc_pipe_open_smb(lsa_pipe, cli->tree, "\\lsarpc"); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); @@ -223,7 +223,7 @@ static BOOL bindtest(struct smbcli_state *cli, goto done; } - status = dcerpc_pipe_open_smb(lsa_pipe->conn, cli->tree, "\\lsarpc"); + status = dcerpc_pipe_open_smb(lsa_pipe, cli->tree, "\\lsarpc"); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); @@ -362,7 +362,7 @@ static NTSTATUS get_usr_handle(struct smbcli_state *cli, goto fail; } - status = dcerpc_pipe_open_smb(samr_pipe->conn, cli->tree, "\\samr"); + status = dcerpc_pipe_open_smb(samr_pipe, cli->tree, "\\samr"); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); @@ -822,7 +822,7 @@ static BOOL auth2(struct smbcli_state *cli, goto done; } - status = dcerpc_pipe_open_smb(net_pipe->conn, cli->tree, "\\netlogon"); + status = dcerpc_pipe_open_smb(net_pipe, cli->tree, "\\netlogon"); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); @@ -923,7 +923,7 @@ static BOOL schan(struct smbcli_state *cli, goto done; } - status = dcerpc_pipe_open_smb(net_pipe->conn, cli->tree, "\\netlogon"); + status = dcerpc_pipe_open_smb(net_pipe, cli->tree, "\\netlogon"); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); @@ -1374,7 +1374,7 @@ static NTSTATUS pipe_bind_smb(TALLOC_CTX *mem_ctx, return NT_STATUS_NO_MEMORY; } - status = dcerpc_pipe_open_smb(result->conn, tree, pipe_name); + status = dcerpc_pipe_open_smb(result, tree, pipe_name); if (!NT_STATUS_IS_OK(status)) { d_printf("dcerpc_pipe_open_smb failed: %s\n", nt_errstr(status)); -- cgit