From 60fd088c480e474c3db8870f1288462a8452cea3 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 26 Feb 2007 05:37:19 +0000 Subject: r21535: - fixed a crash in the RAW-ACLS test. When a dcerpc_pipe is created using the pattern in the clilsa code, it didn't fill in the p->binding structure. This affects nearly all users of dcerpc_pipe_open_smb(), so the simplest fix is to ensure that dcerpc_pipe_open_smb() initialises the binding if its not already there. - re-enable the RAW-ACLS test (This used to be commit d8875c286d2be49c01703d8fd58bbc1842054bd9) --- source4/winbind/wb_async_helpers.c | 2 +- source4/winbind/wb_connect_lsa.c | 2 +- source4/winbind/wb_connect_sam.c | 2 +- source4/winbind/wb_init_domain.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'source4/winbind') diff --git a/source4/winbind/wb_async_helpers.c b/source4/winbind/wb_async_helpers.c index 3a560a9a94..11d675d2e9 100644 --- a/source4/winbind/wb_async_helpers.c +++ b/source4/winbind/wb_async_helpers.c @@ -81,7 +81,7 @@ struct composite_context *wb_get_schannel_creds_send(TALLOC_CTX *mem_ctx, goto failed; } - creq = dcerpc_pipe_open_smb_send(state->p->conn, tree, "\\netlogon"); + creq = dcerpc_pipe_open_smb_send(state->p, tree, "\\netlogon"); if (creq == NULL) { c->status = NT_STATUS_NO_MEMORY; goto failed; diff --git a/source4/winbind/wb_connect_lsa.c b/source4/winbind/wb_connect_lsa.c index 815e131962..6ba14a2f17 100644 --- a/source4/winbind/wb_connect_lsa.c +++ b/source4/winbind/wb_connect_lsa.c @@ -72,7 +72,7 @@ struct composite_context *wb_init_lsa_send(TALLOC_CTX *mem_ctx, state->lsa_pipe = dcerpc_pipe_init(state, result->event_ctx); if (state->lsa_pipe == NULL) goto failed; - ctx = dcerpc_pipe_open_smb_send(state->lsa_pipe->conn, tree, + ctx = dcerpc_pipe_open_smb_send(state->lsa_pipe, tree, "\\lsarpc"); ctx->async.fn = init_lsa_recv_pipe; ctx->async.private_data = state; diff --git a/source4/winbind/wb_connect_sam.c b/source4/winbind/wb_connect_sam.c index 5e5a33d2c1..393c5f8437 100644 --- a/source4/winbind/wb_connect_sam.c +++ b/source4/winbind/wb_connect_sam.c @@ -80,7 +80,7 @@ struct composite_context *wb_connect_sam_send(TALLOC_CTX *mem_ctx, state->samr_pipe = dcerpc_pipe_init(state, result->event_ctx); if (state->samr_pipe == NULL) goto failed; - ctx = dcerpc_pipe_open_smb_send(state->samr_pipe->conn, tree, + ctx = dcerpc_pipe_open_smb_send(state->samr_pipe, tree, "\\samr"); ctx->async.fn = connect_samr_recv_pipe; ctx->async.private_data = state; diff --git a/source4/winbind/wb_init_domain.c b/source4/winbind/wb_init_domain.c index 409f5f2b23..8700dd637e 100644 --- a/source4/winbind/wb_init_domain.c +++ b/source4/winbind/wb_init_domain.c @@ -193,7 +193,7 @@ static void init_domain_recv_netlogoncreds(struct composite_context *ctx) return; } - ctx = dcerpc_pipe_open_smb_send(state->domain->netlogon_pipe->conn, + ctx = dcerpc_pipe_open_smb_send(state->domain->netlogon_pipe, tree, "\\netlogon"); composite_continue(state->ctx, ctx, init_domain_recv_netlogonpipe, state); -- cgit