From 0ef04670398f27d36bf9dabf39a925a2ba2b29d0 Mon Sep 17 00:00:00 2001
From: Jelmer Vernooij <jelmer@samba.org>
Date: Thu, 6 Oct 2005 20:07:53 +0000
Subject: r10787: Fix silly nodiscriminant-issue (This used to be commit
 43a5c863bf81af9b8415b6ccf8a386c36d4fa7f9)

---
 source4/pidl/TODO                            | 4 ++++
 source4/pidl/lib/Parse/Pidl/Samba3/Parser.pm | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

(limited to 'source4')

diff --git a/source4/pidl/TODO b/source4/pidl/TODO
index 1f5875aebe..9fc3a7d904 100644
--- a/source4/pidl/TODO
+++ b/source4/pidl/TODO
@@ -10,3 +10,7 @@
   a (regular) remote error occurs
  
 - support nested elements
+
+- Don't output [ref] pointers for Samba 4?
+ 
+- alternative to subcontext()
diff --git a/source4/pidl/lib/Parse/Pidl/Samba3/Parser.pm b/source4/pidl/lib/Parse/Pidl/Samba3/Parser.pm
index 7cd1255a40..eaab50b553 100644
--- a/source4/pidl/lib/Parse/Pidl/Samba3/Parser.pm
+++ b/source4/pidl/lib/Parse/Pidl/Samba3/Parser.pm
@@ -394,7 +394,7 @@ sub ParseUnion($$$)
 	indent;
 	DeclareArrayVariables($u->{ELEMENTS});
 
-	if (has_property($u, "nodiscriminant")) {
+	unless (has_property($u, "nodiscriminant")) {
 		pidl "if (!prs_uint32(\"switch_value\", ps, depth, &v->switch_value))";
 		pidl "\treturn False;";
 		pidl "";
-- 
cgit