From 2ad086e7f6ab39767cd691b059ab5d78b03d55c0 Mon Sep 17 00:00:00 2001 From: Brendan Powers Date: Mon, 14 Dec 2009 20:32:28 -0500 Subject: s4-dsdb: Add a check to prevent acl_modify from debuging a NULL message Check to see if there were any messages passed to acl_modify before debugging the first one. I think I caused this by some malformed LDIF. Signed-off-by: Andrew Bartlett --- source4/dsdb/samdb/ldb_modules/acl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'source4') diff --git a/source4/dsdb/samdb/ldb_modules/acl.c b/source4/dsdb/samdb/ldb_modules/acl.c index 6cb50b2098..b70b8956bb 100644 --- a/source4/dsdb/samdb/ldb_modules/acl.c +++ b/source4/dsdb/samdb/ldb_modules/acl.c @@ -760,7 +760,11 @@ static int acl_modify(struct ldb_module *module, struct ldb_request *req) NULL }; - DEBUG(10, ("ldb:acl_modify: %s\n", req->op.mod.message->elements[0].name)); + /* Don't print this debug statement if elements[0].name is going to be NULL */ + if(req->op.mod.message->num_elements > 0) + { + DEBUG(10, ("ldb:acl_modify: %s\n", req->op.mod.message->elements[0].name)); + } if (what_is_user(module) == SECURITY_SYSTEM) { return ldb_next_request(module, req); } -- cgit