From 3220c84b72212cb7619ecda60dd8a7c756742e3b Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 6 Jan 2010 16:58:52 +0100 Subject: s4:ntlmssp: use a 'bool ok' helper variable to make the code more readable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit metze Signed-off-by: Günther Deschner --- source4/auth/ntlmssp/ntlmssp_sign.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'source4') diff --git a/source4/auth/ntlmssp/ntlmssp_sign.c b/source4/auth/ntlmssp/ntlmssp_sign.c index 50ad2fdd3a..285369dbb3 100644 --- a/source4/auth/ntlmssp/ntlmssp_sign.c +++ b/source4/auth/ntlmssp/ntlmssp_sign.c @@ -114,12 +114,16 @@ static NTSTATUS ntlmssp_make_packet_signature(struct ntlmssp_state *ntlmssp_stat (unsigned long long)pdu_length)); dump_data(11, sig->data, sig->length); } else { + bool ok; uint32_t crc; crc = crc32_calc_buffer(data, length); - if (!msrpc_gen(sig_mem_ctx, - sig, "dddd", NTLMSSP_SIGN_VERSION, 0, - crc, ntlmssp_state->crypt.ntlm.seq_num)) { + + ok = msrpc_gen(sig_mem_ctx, + sig, "dddd", + NTLMSSP_SIGN_VERSION, 0, crc, + ntlmssp_state->crypt.ntlm.seq_num); + if (!ok) { return NT_STATUS_NO_MEMORY; } ntlmssp_state->crypt.ntlm.seq_num++; @@ -264,12 +268,16 @@ NTSTATUS ntlmssp_seal_packet(struct ntlmssp_state *ntlmssp_state, sig->data+4, 8); } } else { + bool ok; uint32_t crc; crc = crc32_calc_buffer(data, length); - if (!msrpc_gen(sig_mem_ctx, - sig, "dddd", NTLMSSP_SIGN_VERSION, 0, - crc, ntlmssp_state->crypt.ntlm.seq_num)) { + + ok = msrpc_gen(sig_mem_ctx, + sig, "dddd", + NTLMSSP_SIGN_VERSION, 0, crc, + ntlmssp_state->crypt.ntlm.seq_num); + if (!ok) { return NT_STATUS_NO_MEMORY; } -- cgit