From 6568a26f0142950300ae8503b8bc2bffb8a77352 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 14 Nov 2012 08:45:10 +0100 Subject: s4:torture/rpc/handles: try to make the assoc_group test less flakey Just incrementing the assoc_group_id makes it too likely to hit a number that is already in use. Signed-off-by: Stefan Metzmacher Reviewed-by: Michael Adam --- source4/torture/rpc/handles.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'source4') diff --git a/source4/torture/rpc/handles.c b/source4/torture/rpc/handles.c index 9dfa1c0238..3fdce5672e 100644 --- a/source4/torture/rpc/handles.c +++ b/source4/torture/rpc/handles.c @@ -508,7 +508,11 @@ static bool test_handles_random_assoc(struct torture_context *torture) p1->assoc_group_id); transport = p1->conn->transport.transport; - assoc_group_id = p1->assoc_group_id; + /* + * We use ~p1->assoc_group_id instead of p1->assoc_group_id, because + * this way we are less likely to use an id which is already in use. + */ + assoc_group_id = ~p1->assoc_group_id; torture_comment(torture, "connect samr pipe2 with assoc_group_id[0x%08X]- should fail\n", ++assoc_group_id); status = torture_rpc_connection_transport(torture, &p2, &ndr_table_samr, -- cgit