From c559f0057f830898a20851ee4a3a28ebfcd8e264 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze@samba.org>
Date: Mon, 5 Nov 2007 07:09:41 +0100
Subject: r25829: - use DEBUG() instead of printf

- return an error if strings doesn't match on validate

metze
(This used to be commit 4f5ad8cd447f8b44df1bd40f5ee3045d5ab2c3dc)
---
 source4/librpc/rpc/dcerpc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'source4')

diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index 5f7b2991a9..9d58fafcb8 100644
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -1291,7 +1291,7 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
 				       NDR_OUT, st);
 	if (strcmp(s1, s2) != 0) {
 #if 1
-		printf("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2);
+		DEBUG(3,("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2));
 #else
 		/* this is sometimes useful */
 		printf("VALIDATE ERROR\n");
@@ -1299,6 +1299,8 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
 		file_save("gen.dat", s2, strlen(s2));
 		system("diff -u wire.dat gen.dat");
 #endif
+		return ndr_push_error(push, NDR_ERR_VALIDATE,
+				      "failed output validation strings doesn't match");
 	}
 
 	return NT_STATUS_OK;
-- 
cgit