1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
|
/*
ldb database library
Copyright (C) Simo Sorce 2006-2008
Copyright (C) Andrew Bartlett <abartlet@samba.org> 2005-2009
Copyright (C) Stefan Metzmacher 2009
Copyright (C) Matthias Dieter Wallnöfer 2010
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
/*
* Name: ldb
*
* Component: objectclass attribute checking module
*
* Description: this checks the attributes on a directory entry (if they're
* allowed, if the syntax is correct, if mandatory ones are missing,
* denies the deletion of mandatory ones...). The module contains portions
* of the "objectclass" and the "validate_update" LDB module.
*
* Author: Matthias Dieter Wallnöfer
*/
#include "includes.h"
#include "ldb_module.h"
#include "dsdb/samdb/samdb.h"
struct oc_context {
struct ldb_module *module;
struct ldb_request *req;
const struct dsdb_schema *schema;
struct ldb_message *msg;
struct ldb_reply *search_res;
struct ldb_reply *mod_ares;
};
static struct oc_context *oc_init_context(struct ldb_module *module,
struct ldb_request *req)
{
struct ldb_context *ldb;
struct oc_context *ac;
ldb = ldb_module_get_ctx(module);
ac = talloc_zero(req, struct oc_context);
if (ac == NULL) {
ldb_oom(ldb);
return NULL;
}
ac->module = module;
ac->req = req;
ac->schema = dsdb_get_schema(ldb, ac);
return ac;
}
static int oc_op_callback(struct ldb_request *req, struct ldb_reply *ares);
/*
* Checks the correctness of the "dSHeuristics" attribute as described in both
* MS-ADTS 7.1.1.2.4.1.2 dSHeuristics and MS-ADTS 3.1.1.5.3.2 Constraints
*/
static int oc_validate_dsheuristics(struct ldb_message_element *el)
{
if (el->num_values > 0) {
if ((el->values[0].length >= DS_HR_NINETIETH_CHAR) &&
(el->values[0].data[DS_HR_NINETIETH_CHAR-1] != '9')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_EIGHTIETH_CHAR) &&
(el->values[0].data[DS_HR_EIGHTIETH_CHAR-1] != '8')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_SEVENTIETH_CHAR) &&
(el->values[0].data[DS_HR_SEVENTIETH_CHAR-1] != '7')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_SIXTIETH_CHAR) &&
(el->values[0].data[DS_HR_SIXTIETH_CHAR-1] != '6')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_FIFTIETH_CHAR) &&
(el->values[0].data[DS_HR_FIFTIETH_CHAR-1] != '5')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_FOURTIETH_CHAR) &&
(el->values[0].data[DS_HR_FOURTIETH_CHAR-1] != '4')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_THIRTIETH_CHAR) &&
(el->values[0].data[DS_HR_THIRTIETH_CHAR-1] != '3')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_TWENTIETH_CHAR) &&
(el->values[0].data[DS_HR_TWENTIETH_CHAR-1] != '2')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
if ((el->values[0].length >= DS_HR_TENTH_CHAR) &&
(el->values[0].data[DS_HR_TENTH_CHAR-1] != '1')) {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
}
return LDB_SUCCESS;
}
/*
auto normalise values on input
*/
static int oc_auto_normalise(struct ldb_context *ldb, const struct dsdb_attribute *attr,
struct ldb_message *msg, struct ldb_message_element *el)
{
int i;
bool values_copied = false;
for (i=0; i<el->num_values; i++) {
struct ldb_val v;
int ret;
ret = attr->ldb_schema_attribute->syntax->canonicalise_fn(ldb, el->values, &el->values[i], &v);
if (ret != LDB_SUCCESS) {
return ret;
}
if (data_blob_cmp(&v, &el->values[i]) == 0) {
/* no need to replace it */
talloc_free(v.data);
continue;
}
/* we need to copy the values array on the first change */
if (!values_copied) {
struct ldb_val *v2;
v2 = talloc_array(msg->elements, struct ldb_val, el->num_values);
if (v2 == NULL) {
return ldb_oom(ldb);
}
memcpy(v2, el->values, sizeof(struct ldb_val) * el->num_values);
el->values = v2;
values_copied = true;
}
el->values[i] = v;
}
return LDB_SUCCESS;
}
static int attr_handler(struct oc_context *ac)
{
struct ldb_context *ldb;
struct ldb_message *msg;
struct ldb_request *child_req;
const struct dsdb_attribute *attr;
unsigned int i;
int ret;
WERROR werr;
struct dsdb_syntax_ctx syntax_ctx;
ldb = ldb_module_get_ctx(ac->module);
if (ac->req->operation == LDB_ADD) {
msg = ldb_msg_copy_shallow(ac, ac->req->op.add.message);
} else {
msg = ldb_msg_copy_shallow(ac, ac->req->op.mod.message);
}
if (msg == NULL) {
return ldb_oom(ldb);
}
ac->msg = msg;
/* initialize syntax checking context */
dsdb_syntax_ctx_init(&syntax_ctx, ldb, ac->schema);
/* Check if attributes exist in the schema, if the values match,
* if they're not operational and fix the names to the match the schema
* case */
for (i = 0; i < msg->num_elements; i++) {
attr = dsdb_attribute_by_lDAPDisplayName(ac->schema,
msg->elements[i].name);
if (attr == NULL) {
if (ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK) &&
ac->req->operation != LDB_ADD) {
/* we allow this for dbcheck to fix
broken attributes */
goto no_attribute;
}
ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' was not found in the schema!",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_NO_SUCH_ATTRIBUTE;
}
if ((attr->linkID & 1) == 1 &&
!ldb_request_get_control(ac->req, LDB_CONTROL_RELAX_OID) &&
!ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
/* Odd is for the target. Illegal to modify */
ldb_asprintf_errstring(ldb,
"objectclass_attrs: attribute '%s' on entry '%s' must not be modified directly, it is a linked attribute",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_UNWILLING_TO_PERFORM;
}
if (!(msg->elements[i].flags & LDB_FLAG_INTERNAL_DISABLE_VALIDATION)) {
werr = attr->syntax->validate_ldb(&syntax_ctx, attr,
&msg->elements[i]);
if (!W_ERROR_IS_OK(werr) &&
!ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' contains at least one invalid value!",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
}
}
if ((attr->systemFlags & DS_FLAG_ATTR_IS_CONSTRUCTED) != 0) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' is constructed!",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
if (ac->req->operation == LDB_ADD) {
return LDB_ERR_UNDEFINED_ATTRIBUTE_TYPE;
} else {
return LDB_ERR_CONSTRAINT_VIOLATION;
}
}
/* "dSHeuristics" syntax check */
if (ldb_attr_cmp(attr->lDAPDisplayName, "dSHeuristics") == 0) {
ret = oc_validate_dsheuristics(&(msg->elements[i]));
if (ret != LDB_SUCCESS) {
return ret;
}
}
/* auto normalise some attribute values */
if (attr->syntax->auto_normalise) {
ret = oc_auto_normalise(ldb, attr, msg, &msg->elements[i]);
if (ret != LDB_SUCCESS) {
return ret;
}
}
/* Substitute the attribute name to match in case */
msg->elements[i].name = attr->lDAPDisplayName;
}
no_attribute:
if (ac->req->operation == LDB_ADD) {
ret = ldb_build_add_req(&child_req, ldb, ac,
msg, ac->req->controls,
ac, oc_op_callback, ac->req);
LDB_REQ_SET_LOCATION(child_req);
} else {
ret = ldb_build_mod_req(&child_req, ldb, ac,
msg, ac->req->controls,
ac, oc_op_callback, ac->req);
LDB_REQ_SET_LOCATION(child_req);
}
if (ret != LDB_SUCCESS) {
return ret;
}
return ldb_next_request(ac->module, child_req);
}
/*
these are attributes which are left over from old ways of doing
things in ldb, and are harmless
*/
static const char *harmless_attrs[] = { "parentGUID", NULL };
static int attr_handler2(struct oc_context *ac)
{
struct ldb_context *ldb;
struct ldb_message_element *oc_element;
struct ldb_message *msg;
const char **must_contain, **may_contain, **found_must_contain;
/* There exists a hardcoded delete-protected attributes list in AD */
const char *del_prot_attributes[] = { "nTSecurityDescriptor",
"objectSid", "sAMAccountType", "sAMAccountName", "groupType",
"primaryGroupID", "userAccountControl", "accountExpires",
"badPasswordTime", "badPwdCount", "codePage", "countryCode",
"lastLogoff", "lastLogon", "logonCount", "pwdLastSet", NULL },
**l;
const struct dsdb_attribute *attr;
unsigned int i;
bool found;
bool isSchemaAttr = false;
ldb = ldb_module_get_ctx(ac->module);
if (ac->search_res == NULL) {
return ldb_operr(ldb);
}
/* We rely here on the preceeding "objectclass" LDB module which did
* already fix up the objectclass list (inheritance, order...). */
oc_element = ldb_msg_find_element(ac->search_res->message,
"objectClass");
if (oc_element == NULL) {
return ldb_operr(ldb);
}
/* LSA-specific object classes are not allowed to be created over LDAP,
* so we need to tell if this connection is internal (trusted) or not
* (untrusted).
*
* Hongwei Sun from Microsoft explains:
* The constraint in 3.1.1.5.2.2 MS-ADTS means that LSA objects cannot
* be added or modified through the LDAP interface, instead they can
* only be handled through LSA Policy API. This is also explained in
* 7.1.6.9.7 MS-ADTS as follows:
* "Despite being replicated normally between peer DCs in a domain,
* the process of creating or manipulating TDOs is specifically
* restricted to the LSA Policy APIs, as detailed in [MS-LSAD] section
* 3.1.1.5. Unlike other objects in the DS, TDOs may not be created or
* manipulated by client machines over the LDAPv3 transport."
*/
for (i = 0; i < oc_element->num_values; i++) {
char * attname = (char *)oc_element->values[i].data;
if (ldb_req_is_untrusted(ac->req)) {
if (strcmp(attname, "secret") == 0 ||
strcmp(attname, "trustedDomain") == 0) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: LSA objectclasses (entry '%s') cannot be created or changed over LDAP!",
ldb_dn_get_linearized(ac->search_res->message->dn));
return LDB_ERR_UNWILLING_TO_PERFORM;
}
}
if (strcmp(attname, "attributeSchema") == 0) {
isSchemaAttr = true;
}
}
must_contain = dsdb_full_attribute_list(ac, ac->schema, oc_element,
DSDB_SCHEMA_ALL_MUST);
may_contain = dsdb_full_attribute_list(ac, ac->schema, oc_element,
DSDB_SCHEMA_ALL_MAY);
found_must_contain = const_str_list(str_list_copy(ac, must_contain));
if ((must_contain == NULL) || (may_contain == NULL)
|| (found_must_contain == NULL)) {
return ldb_operr(ldb);
}
/* Check the delete-protected attributes list */
msg = ac->search_res->message;
for (l = del_prot_attributes; *l != NULL; l++) {
struct ldb_message_element *el;
el = ldb_msg_find_element(ac->msg, *l);
if (el == NULL) {
/*
* It was not specified in the add or modify,
* so it doesn't need to be in the stored record
*/
continue;
}
found = str_list_check_ci(must_contain, *l);
if (!found) {
found = str_list_check_ci(may_contain, *l);
}
if (found && (ldb_msg_find_element(msg, *l) == NULL)) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: delete protected attribute '%s' on entry '%s' missing!",
*l,
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_UNWILLING_TO_PERFORM;
}
}
/* Check if all specified attributes are valid in the given
* objectclasses and if they meet additional schema restrictions. */
for (i = 0; i < msg->num_elements; i++) {
attr = dsdb_attribute_by_lDAPDisplayName(ac->schema,
msg->elements[i].name);
if (attr == NULL) {
if (ldb_request_get_control(ac->req, DSDB_CONTROL_DBCHECK)) {
/* allow this to make it possible for dbcheck
to remove bad attributes */
continue;
}
return ldb_operr(ldb);
}
/* We can use "str_list_check" with "strcmp" here since the
* attribute information from the schema are always equal
* up-down-cased. */
found = str_list_check(must_contain, attr->lDAPDisplayName);
if (found) {
str_list_remove(found_must_contain, attr->lDAPDisplayName);
} else {
found = str_list_check(may_contain, attr->lDAPDisplayName);
}
if (!found) {
found = str_list_check(harmless_attrs, attr->lDAPDisplayName);
}
if (!found) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: attribute '%s' on entry '%s' does not exist in the specified objectclasses!",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_OBJECT_CLASS_VIOLATION;
}
}
if (found_must_contain[0] != NULL &&
ldb_msg_check_string_attribute(msg, "isDeleted", "TRUE") == 0) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: at least one mandatory attribute ('%s') on entry '%s' wasn't specified!",
found_must_contain[0],
ldb_dn_get_linearized(msg->dn));
return LDB_ERR_OBJECT_CLASS_VIOLATION;
}
if (isSchemaAttr) {
/* Before really adding an attribute in the database,
* let's check that we can translate it into a dbsd_attribute and
* that we can find a valid syntax object.
* If not it's better to reject this attribute than not be able
* to start samba next time due to schema being unloadable.
*/
struct dsdb_attribute *att = talloc(ac, struct dsdb_attribute);
const struct dsdb_syntax *attrSyntax;
WERROR status;
status= dsdb_attribute_from_ldb(ac->schema, msg, att);
if (!W_ERROR_IS_OK(status)) {
ldb_set_errstring(ldb,
"objectclass: failed to translate the schemaAttribute to a dsdb_attribute");
return LDB_ERR_UNWILLING_TO_PERFORM;
}
attrSyntax = dsdb_syntax_for_attribute(att);
if (!attrSyntax) {
ldb_set_errstring(ldb,
"objectclass: unknown attribute syntax");
return LDB_ERR_UNWILLING_TO_PERFORM;
}
}
return ldb_module_done(ac->req, ac->mod_ares->controls,
ac->mod_ares->response, LDB_SUCCESS);
}
static int get_search_callback(struct ldb_request *req, struct ldb_reply *ares)
{
struct ldb_context *ldb;
struct oc_context *ac;
int ret;
ac = talloc_get_type(req->context, struct oc_context);
ldb = ldb_module_get_ctx(ac->module);
if (!ares) {
return ldb_module_done(ac->req, NULL, NULL,
LDB_ERR_OPERATIONS_ERROR);
}
if (ares->error != LDB_SUCCESS) {
return ldb_module_done(ac->req, ares->controls,
ares->response, ares->error);
}
ldb_reset_err_string(ldb);
switch (ares->type) {
case LDB_REPLY_ENTRY:
if (ac->search_res != NULL) {
ldb_set_errstring(ldb, "Too many results");
talloc_free(ares);
return ldb_module_done(ac->req, NULL, NULL,
LDB_ERR_OPERATIONS_ERROR);
}
ac->search_res = talloc_steal(ac, ares);
break;
case LDB_REPLY_REFERRAL:
/* ignore */
talloc_free(ares);
break;
case LDB_REPLY_DONE:
talloc_free(ares);
ret = attr_handler2(ac);
if (ret != LDB_SUCCESS) {
return ldb_module_done(ac->req, NULL, NULL, ret);
}
break;
}
return LDB_SUCCESS;
}
static int oc_op_callback(struct ldb_request *req, struct ldb_reply *ares)
{
struct oc_context *ac;
struct ldb_context *ldb;
struct ldb_request *search_req;
struct ldb_dn *base_dn;
int ret;
ac = talloc_get_type(req->context, struct oc_context);
ldb = ldb_module_get_ctx(ac->module);
if (!ares) {
return ldb_module_done(ac->req, NULL, NULL,
LDB_ERR_OPERATIONS_ERROR);
}
if (ares->type == LDB_REPLY_REFERRAL) {
return ldb_module_send_referral(ac->req, ares->referral);
}
if (ares->error != LDB_SUCCESS) {
return ldb_module_done(ac->req, ares->controls, ares->response,
ares->error);
}
if (ares->type != LDB_REPLY_DONE) {
talloc_free(ares);
return ldb_module_done(ac->req, NULL, NULL,
LDB_ERR_OPERATIONS_ERROR);
}
ac->search_res = NULL;
ac->mod_ares = talloc_steal(ac, ares);
/* This looks up all attributes of our just added/modified entry */
base_dn = ac->req->operation == LDB_ADD ? ac->req->op.add.message->dn
: ac->req->op.mod.message->dn;
ret = ldb_build_search_req(&search_req, ldb, ac, base_dn,
LDB_SCOPE_BASE, "(objectClass=*)",
NULL, NULL, ac,
get_search_callback, ac->req);
LDB_REQ_SET_LOCATION(search_req);
if (ret != LDB_SUCCESS) {
return ldb_module_done(ac->req, NULL, NULL, ret);
}
ret = ldb_request_add_control(search_req, LDB_CONTROL_SHOW_RECYCLED_OID,
true, NULL);
if (ret != LDB_SUCCESS) {
return ldb_module_done(ac->req, NULL, NULL, ret);
}
ret = ldb_next_request(ac->module, search_req);
if (ret != LDB_SUCCESS) {
return ldb_module_done(ac->req, NULL, NULL, ret);
}
/* "ldb_module_done" isn't called here since we need to do additional
* checks. It is called at the end of "attr_handler2". */
return LDB_SUCCESS;
}
static int objectclass_attrs_add(struct ldb_module *module,
struct ldb_request *req)
{
struct ldb_context *ldb;
struct oc_context *ac;
ldb = ldb_module_get_ctx(module);
ldb_debug(ldb, LDB_DEBUG_TRACE, "objectclass_attrs_add\n");
/* do not manipulate our control entries */
if (ldb_dn_is_special(req->op.add.message->dn)) {
return ldb_next_request(module, req);
}
ac = oc_init_context(module, req);
if (ac == NULL) {
return ldb_operr(ldb);
}
/* without schema, there isn't much to do here */
if (ac->schema == NULL) {
talloc_free(ac);
return ldb_next_request(module, req);
}
return attr_handler(ac);
}
static int objectclass_attrs_modify(struct ldb_module *module,
struct ldb_request *req)
{
struct ldb_context *ldb;
struct oc_context *ac;
ldb = ldb_module_get_ctx(module);
ldb_debug(ldb, LDB_DEBUG_TRACE, "objectclass_attrs_modify\n");
/* do not manipulate our control entries */
if (ldb_dn_is_special(req->op.mod.message->dn)) {
return ldb_next_request(module, req);
}
ac = oc_init_context(module, req);
if (ac == NULL) {
return ldb_operr(ldb);
}
/* without schema, there isn't much to do here */
if (ac->schema == NULL) {
talloc_free(ac);
return ldb_next_request(module, req);
}
return attr_handler(ac);
}
static const struct ldb_module_ops ldb_objectclass_attrs_module_ops = {
.name = "objectclass_attrs",
.add = objectclass_attrs_add,
.modify = objectclass_attrs_modify
};
int ldb_objectclass_attrs_module_init(const char *version)
{
LDB_MODULE_CHECK_VERSION(version);
return ldb_register_module(&ldb_objectclass_attrs_module_ops);
}
|