summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2012-11-15 07:33:30 +0100
committerJakub Hrozek <jhrozek@redhat.com>2012-11-19 14:21:00 +0100
commitb893cb4f3567d2dd571debf6dbf0d50a38f86823 (patch)
treee23769d4a10e25dd85775ba35e9d1afd19d60dad
parentc9e8154b32fb3fea639478c203bb1079c18e7bca (diff)
downloadsssd-b893cb4f3567d2dd571debf6dbf0d50a38f86823.tar.gz
sssd-b893cb4f3567d2dd571debf6dbf0d50a38f86823.tar.bz2
sssd-b893cb4f3567d2dd571debf6dbf0d50a38f86823.zip
LDAP: Fix saving empty groups
https://fedorahosted.org/sssd/ticket/1647 A logic bug in the LDAP provider causes an attempt to allocate a zero-length array for group members while processing an empty group. The allocation would return NULL and saving the empty group would fail.
-rw-r--r--src/providers/ldap/sdap_async_groups.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c
index ce08b88a..b8457e64 100644
--- a/src/providers/ldap/sdap_async_groups.c
+++ b/src/providers/ldap/sdap_async_groups.c
@@ -433,9 +433,11 @@ static int sdap_save_group(TALLOC_CTX *memctx,
el->values = gh->values;
el->num_values = gh->num_values;
+ cnt = el->num_values + el1->num_values;
+ DEBUG(SSSDBG_TRACE_FUNC, ("Group %s has %d members\n", name, cnt));
+
/* Now process RFC2307bis ghost hash table */
- if (ghosts != NULL) {
- cnt = el->num_values + el1->num_values;
+ if (ghosts && cnt > 0) {
el->values = talloc_realloc(attrs, el->values, struct ldb_val,
cnt);
if (el->values == NULL) {