diff options
author | Stephen Gallagher <sgallagh@redhat.com> | 2009-12-15 14:18:06 -0500 |
---|---|---|
committer | Stephen Gallagher <sgallagh@redhat.com> | 2009-12-15 15:37:29 -0500 |
commit | 860d9f273e36ffb69f16377949b8ba9444ac99bf (patch) | |
tree | e845ec11bc26825fe60f41438e7111301ee9a35d | |
parent | 15419ddafb9af79cce99a80ad3d0503d07ada55d (diff) | |
download | sssd-860d9f273e36ffb69f16377949b8ba9444ac99bf.tar.gz sssd-860d9f273e36ffb69f16377949b8ba9444ac99bf.tar.bz2 sssd-860d9f273e36ffb69f16377949b8ba9444ac99bf.zip |
Fix tight loop in monitor
If the domain heartbeat time was explicitly set in the
configuration to 0, we would enter a tight loop in the heartbeat
check and never answer requests from the child processes.
-rw-r--r-- | server/man/sssd.conf.5.xml | 8 | ||||
-rw-r--r-- | server/monitor/monitor.c | 5 |
2 files changed, 9 insertions, 4 deletions
diff --git a/server/man/sssd.conf.5.xml b/server/man/sssd.conf.5.xml index 95fd606e..cb378c84 100644 --- a/server/man/sssd.conf.5.xml +++ b/server/man/sssd.conf.5.xml @@ -362,12 +362,12 @@ <term>timeout (integer)</term> <listitem> <para> - Timeout in seconds for this particular domain. - Raising this timeout might prove useful for slower - backends like distant LDAP servers. + Timeout in seconds between heartbeats for this domain. + This is used to ensure that the backend process is + alive and capable of answering requests. </para> <para> - Default: 0 (no timeout) + Default: 10 </para> </listitem> </varlistentry> diff --git a/server/monitor/monitor.c b/server/monitor/monitor.c index d47b3a80..30df2cb9 100644 --- a/server/monitor/monitor.c +++ b/server/monitor/monitor.c @@ -1060,6 +1060,11 @@ static int get_service_config(struct mt_ctx *ctx, const char *name, return ret; } + /* 'timeout = 0' should be translated to the default */ + if (svc->ping_time == 0) { + svc->ping_time = MONITOR_DEF_PING_TIME; + } + *svc_cfg = svc; talloc_free(path); |