diff options
author | Stef Walter <stefw@gnome.org> | 2012-04-24 11:32:04 +0200 |
---|---|---|
committer | Stephen Gallagher <sgallagh@redhat.com> | 2012-05-01 14:22:50 -0400 |
commit | c8a124ac1b03d83016bda02cad5a369ce6fb1cd7 (patch) | |
tree | 9f5ea0df345b3ae8008d1a3cd6c3398dfc67bf13 /src/providers | |
parent | 24ba5b87c9a2c01deddc9be867e4951e2a397146 (diff) | |
download | sssd-c8a124ac1b03d83016bda02cad5a369ce6fb1cd7.tar.gz sssd-c8a124ac1b03d83016bda02cad5a369ce6fb1cd7.tar.bz2 sssd-c8a124ac1b03d83016bda02cad5a369ce6fb1cd7.zip |
execv, excvp and exec_child never return EOK
* So don't need to handle that case
Diffstat (limited to 'src/providers')
-rw-r--r-- | src/providers/ipa/ipa_dyndns.c | 8 | ||||
-rw-r--r-- | src/providers/ldap/sdap_child_helpers.c | 8 |
2 files changed, 6 insertions, 10 deletions
diff --git a/src/providers/ipa/ipa_dyndns.c b/src/providers/ipa/ipa_dyndns.c index 71fc27bc..4224919b 100644 --- a/src/providers/ipa/ipa_dyndns.c +++ b/src/providers/ipa/ipa_dyndns.c @@ -1015,11 +1015,9 @@ fork_nsupdate_send(struct ipa_nsupdate_ctx *ctx) } errno = 0; - ret = execv(NSUPDATE_PATH, args); - if(ret == -1) { - err = errno; - DEBUG(1, ("execv failed [%d][%s].\n", err, strerror(err))); - } + execv(NSUPDATE_PATH, args); + err = errno; + DEBUG(SSSDBG_CRIT_FAILURE, ("execv failed [%d][%s].\n", err, strerror(err))); return NULL; } diff --git a/src/providers/ldap/sdap_child_helpers.c b/src/providers/ldap/sdap_child_helpers.c index 704c89ec..eeb5e5f0 100644 --- a/src/providers/ldap/sdap_child_helpers.c +++ b/src/providers/ldap/sdap_child_helpers.c @@ -107,11 +107,9 @@ static errno_t sdap_fork_child(struct tevent_context *ev, err = exec_child(child, pipefd_to_child, pipefd_from_child, LDAP_CHILD, ldap_child_debug_fd); - if (err != EOK) { - DEBUG(1, ("Could not exec LDAP child: [%d][%s].\n", - err, strerror(err))); - return err; - } + DEBUG(SSSDBG_CRIT_FAILURE, ("Could not exec LDAP child: [%d][%s].\n", + err, strerror(err))); + return err; } else if (pid > 0) { /* parent */ child->pid = pid; child->read_from_child_fd = pipefd_from_child[0]; |