From b46635a151ca93b74a45bbaa3f782da43b3692f9 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Thu, 8 Dec 2011 07:59:43 -0500 Subject: LDAP: Fix missing break statements in force_tls Also add a default case to protect against bad input --- src/providers/ldap/sdap_async_connection.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'src/providers/ldap/sdap_async_connection.c') diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c index 21b3d641..6350e337 100644 --- a/src/providers/ldap/sdap_async_connection.c +++ b/src/providers/ldap/sdap_async_connection.c @@ -1229,12 +1229,18 @@ static void sdap_cli_resolve_done(struct tevent_req *subreq) bool use_tls; switch (state->force_tls) { - case CON_TLS_DFL: - use_tls = dp_opt_get_bool(state->opts->basic, SDAP_ID_TLS); - case CON_TLS_ON: - use_tls = true; - case CON_TLS_OFF: - use_tls = false; + case CON_TLS_DFL: + use_tls = dp_opt_get_bool(state->opts->basic, SDAP_ID_TLS); + break; + case CON_TLS_ON: + use_tls = true; + break; + case CON_TLS_OFF: + use_tls = false; + break; + default: + tevent_req_error(req, EINVAL); + break; } ret = be_resolve_server_recv(subreq, &state->srv); -- cgit