summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Franzke <benjaminfranzke@googlemail.com>2013-11-18 17:02:33 +0100
committerBenjamin Franzke <benjaminfranzke@googlemail.com>2013-11-18 17:02:33 +0100
commit68be32aa86bd28182130688c6a4f7d8c14c80450 (patch)
treeb1933fd9ae236e98e69e9e1dc659aa2cdf3b3fe4
parent5041a5d5a574449638e7579827d9b67ed1450b0d (diff)
downloadcmumble-68be32aa86bd28182130688c6a4f7d8c14c80450.tar.gz
cmumble-68be32aa86bd28182130688c6a4f7d8c14c80450.tar.bz2
cmumble-68be32aa86bd28182130688c6a4f7d8c14c80450.zip
Revert "recv_user_state: Verify needed, but optional values"
This reverts commit f3b388b80daebb13398f2b6b269eda0aa947e469.
-rw-r--r--src/cmumble.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/cmumble.c b/src/cmumble.c
index 760486f..c566780 100644
--- a/src/cmumble.c
+++ b/src/cmumble.c
@@ -153,9 +153,6 @@ recv_user_state(MumbleProto__UserState *state, struct cmumble *cm)
{
struct cmumble_user *user = NULL;
- if (!state->has_session)
- return;
-
user = find_user(cm, state->session);
if (user) {
/* update */
@@ -166,10 +163,6 @@ recv_user_state(MumbleProto__UserState *state, struct cmumble *cm)
return;
}
- /* verify input data */
- if (!state->has_user_id || !state->has_channel_id || !state->name)
- return;
-
user = g_slice_new0(struct cmumble_user);
if (user == NULL) {
g_printerr("Out of memory.\n");
@@ -179,8 +172,6 @@ recv_user_state(MumbleProto__UserState *state, struct cmumble *cm)
user->session = state->session;
user->name = g_strdup(state->name);
user->id = state->user_id;
- /* FIXME: error out if channel not found?
- * That looks like malicious data. */
user->channel = find_channel(cm, state->channel_id);
if (cm->session == user->session)