summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2013-03-28 08:55:11 -0700
committerDavid Disseldorp <ddiss@samba.org>2013-04-02 21:54:33 +0200
commitb986a3a9c988c6ec29c0e0a2f8609d5132e952f4 (patch)
tree7ca7aa61d5e3d51a260ce89ec65ebb160852f0af
parent9b94de161f30bb34c666c0cf0cc94250e6a7b863 (diff)
downloadsamba-b986a3a9c988c6ec29c0e0a2f8609d5132e952f4.tar.gz
samba-b986a3a9c988c6ec29c0e0a2f8609d5132e952f4.tar.bz2
samba-b986a3a9c988c6ec29c0e0a2f8609d5132e952f4.zip
Ensure EA value is allocated on the right context.
Ensure we free on error condition (tidyup, not a leak). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Tue Apr 2 21:54:33 CEST 2013 on sn-devel-104
-rw-r--r--source3/smbd/trans2.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 4cdd2394ca..5781c61943 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -350,11 +350,12 @@ static NTSTATUS get_ea_list_from_file_path(TALLOC_CTX *mem_ctx, connection_struc
return NT_STATUS_NO_MEMORY;
}
- status = get_ea_value(mem_ctx, conn, fsp,
+ status = get_ea_value(listp, conn, fsp,
fname, names[i],
&listp->ea);
if (!NT_STATUS_IS_OK(status)) {
+ TALLOC_FREE(listp);
return status;
}