diff options
| author | Jeremy Allison <jra@samba.org> | 2010-01-25 17:38:55 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2010-01-25 17:38:55 -0800 |
| commit | 1e2e92f54d90c59a2a340728d3adc3cac1dd8133 (patch) | |
| tree | 424bda864869059d228d89950f277e0232e762b4 | |
| parent | 2fff1e13f1d0f450a1efc771e209a3b3f94fb7c4 (diff) | |
| download | samba-1e2e92f54d90c59a2a340728d3adc3cac1dd8133.tar.gz samba-1e2e92f54d90c59a2a340728d3adc3cac1dd8133.tar.bz2 samba-1e2e92f54d90c59a2a340728d3adc3cac1dd8133.zip | |
Correct fix for unused variable return from ndr_decode. Use it :-).
Jeremy.
| -rw-r--r-- | source3/smbd/dosmode.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c index aaef09bc85..e5d6bc32e8 100644 --- a/source3/smbd/dosmode.c +++ b/source3/smbd/dosmode.c @@ -264,6 +264,14 @@ static bool get_ea_dos_attribute(connection_struct *conn, ndr_err = ndr_pull_struct_blob(&blob, talloc_tos(), NULL, &dosattrib, (ndr_pull_flags_fn_t)ndr_pull_xattr_DOSATTRIB); + if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { + DEBUG(1,("get_ea_dos_attributes: bad ndr decode " + "from EA on file %s: Error = %s\n", + smb_fname_str_dbg(smb_fname), + ndr_errstr(ndr_err))); + return false; + } + DEBUG(10,("get_ea_dos_attribute: %s attr = %s\n", smb_fname_str_dbg(smb_fname), dosattrib.attrib_hex)); |