diff options
| author | Volker Lendecke <vl@samba.org> | 2011-03-16 21:50:59 +0100 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2011-03-16 22:07:24 +0100 |
| commit | 889e03617d6153040bbf462b631d9e752220281b (patch) | |
| tree | acee89c024453ed2e9edfc9321c6c85c1d1f1f6a | |
| parent | 37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4 (diff) | |
| download | samba-889e03617d6153040bbf462b631d9e752220281b.tar.gz samba-889e03617d6153040bbf462b631d9e752220281b.tar.bz2 samba-889e03617d6153040bbf462b631d9e752220281b.zip | |
s3: Fix Coverity ID 2232, REVERSE_INULL
No point checking for !cli after dereferencing it
| -rw-r--r-- | source3/rpc_client/cli_pipe.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c index ebbe849ac7..0109bdae72 100644 --- a/source3/rpc_client/cli_pipe.c +++ b/source3/rpc_client/cli_pipe.c @@ -3256,7 +3256,7 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx, struct rpc_pipe_client *cli, DATA_BLOB *session_key) { - struct pipe_auth_data *a = cli->auth; + struct pipe_auth_data *a; struct schannel_state *schannel_auth; struct auth_ntlmssp_state *ntlmssp_ctx; struct spnego_context *spnego_ctx; @@ -3268,7 +3268,9 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx, return NT_STATUS_INVALID_PARAMETER; } - if (!cli->auth) { + a = cli->auth; + + if (a == NULL) { return NT_STATUS_INVALID_PARAMETER; } |