summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vlendec@samba.org>2006-03-12 18:01:36 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:15:20 -0500
commitf04579aaf88eede823ef7b9e9035603ae8746f21 (patch)
treee2b3e612aa430691fa3ff8406a26fdcdf2d3874e
parentb84029452b37555944cfc77c9651a50278c67b11 (diff)
downloadsamba-f04579aaf88eede823ef7b9e9035603ae8746f21.tar.gz
samba-f04579aaf88eede823ef7b9e9035603ae8746f21.tar.bz2
samba-f04579aaf88eede823ef7b9e9035603ae8746f21.zip
r14249: We've dereferenced the_acl before, no point in checking.
Fix Coverity bug # 128. Volker (This used to be commit 84e9e73f3c71a0ccef76d56bc72dcd21160ed286)
-rw-r--r--source3/lib/secdesc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/lib/secdesc.c b/source3/lib/secdesc.c
index a443f90dbb..11f963fa0e 100644
--- a/source3/lib/secdesc.c
+++ b/source3/lib/secdesc.c
@@ -433,7 +433,7 @@ SEC_DESC_BUF *se_create_child_secdesc(TALLOC_CTX *ctx, SEC_DESC *parent_ctr,
if (!(new_ace_list = TALLOC_ARRAY(ctx, SEC_ACE, the_acl->num_aces)))
return NULL;
- for (i = 0; the_acl && i < the_acl->num_aces; i++) {
+ for (i = 0; i < the_acl->num_aces; i++) {
SEC_ACE *ace = &the_acl->ace[i];
SEC_ACE *new_ace = &new_ace_list[new_ace_list_ndx];
uint8 new_flags = 0;