summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2013-10-08 15:01:38 -0700
committerDavid Disseldorp <ddiss@samba.org>2013-10-09 03:50:56 +0200
commit0de6282e00e1052d8facf6bcad69f2b8fa547895 (patch)
tree10c05a74a0156dc226bcf46e469fd4a40bde42d9
parent02393156de280748d4e87f231d477fa70437a8a0 (diff)
downloadsamba-0de6282e00e1052d8facf6bcad69f2b8fa547895.tar.gz
samba-0de6282e00e1052d8facf6bcad69f2b8fa547895.tar.bz2
samba-0de6282e00e1052d8facf6bcad69f2b8fa547895.zip
Fix bug #10187 - Missing talloc_free can leak stackframe in error path.
Fix error path. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Oct 9 03:50:56 CEST 2013 on sn-devel-104
-rw-r--r--source3/winbindd/winbindd_msrpc.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c
index e86838cf58..61447d3acf 100644
--- a/source3/winbindd/winbindd_msrpc.c
+++ b/source3/winbindd/winbindd_msrpc.c
@@ -944,8 +944,9 @@ static NTSTATUS msrpc_trusted_domains(struct winbindd_domain *domain,
}
status = cm_connect_lsa(domain, tmp_ctx, &lsa_pipe, &lsa_policy);
- if (!NT_STATUS_IS_OK(status))
- return status;
+ if (!NT_STATUS_IS_OK(status)) {
+ goto done;
+ }
status = rpc_trusted_domains(tmp_ctx,
lsa_pipe,