diff options
| author | Jim McDonough <jmcd@samba.org> | 2006-03-15 02:31:11 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:15:29 -0500 |
| commit | 0e0d21dd3deaa5c08e04de796c7abe32125c213d (patch) | |
| tree | f9b416691454a6edc2abfd36afb1e146b270aaf0 | |
| parent | fa42d65a47d8ac35cddd485ae53e7f03a8061e88 (diff) | |
| download | samba-0e0d21dd3deaa5c08e04de796c7abe32125c213d.tar.gz samba-0e0d21dd3deaa5c08e04de796c7abe32125c213d.tar.bz2 samba-0e0d21dd3deaa5c08e04de796c7abe32125c213d.zip | |
r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size. Zero out the sec_desc
buffer to prevent this. This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28ce361628df137c9aef02739aca062db)
| -rw-r--r-- | source3/libmsrpc/cac_winreg.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/source3/libmsrpc/cac_winreg.c b/source3/libmsrpc/cac_winreg.c index aa847602cc..acd83f4076 100644 --- a/source3/libmsrpc/cac_winreg.c +++ b/source3/libmsrpc/cac_winreg.c @@ -831,6 +831,8 @@ int cac_RegGetKeySecurity(CacServerHandle *hnd, TALLOC_CTX *mem_ctx, struct RegG uint32 buf_size; SEC_DESC_BUF buf; + ZERO_STRUCT(buf); + if(!hnd) return CAC_FAILURE; |