diff options
author | Tim Potter <tpot@samba.org> | 2005-11-10 03:48:56 +0000 |
---|---|---|
committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 13:46:01 -0500 |
commit | 0eeedb97a5b28c20edcf13d37e52b8e8b98567f6 (patch) | |
tree | 91bfe583a974b35795fada1c7b53a7a288bd8d22 | |
parent | 16a9bfd33f52cb398c6d3d3472d9dbe53927370d (diff) | |
download | samba-0eeedb97a5b28c20edcf13d37e52b8e8b98567f6.tar.gz samba-0eeedb97a5b28c20edcf13d37e52b8e8b98567f6.tar.bz2 samba-0eeedb97a5b28c20edcf13d37e52b8e8b98567f6.zip |
r11626: Fix unhandled enum in case statement warnings by noting appropriately
that some values aren't handled. The remaining warnings I think are
actual bugs or required functionality that is missing (mostly lack of
server side Unix extensions).
(This used to be commit 03c7da27a06736f2a27d76e6a00a24ab54453af9)
-rw-r--r-- | source4/client/client.c | 3 | ||||
-rw-r--r-- | source4/libcli/raw/rawsetfileinfo.c | 12 | ||||
-rw-r--r-- | source4/torture/gentest.c | 8 | ||||
-rw-r--r-- | source4/torture/rpc/samsync.c | 17 | ||||
-rw-r--r-- | source4/winbind/wb_samba3_protocol.c | 43 |
5 files changed, 83 insertions, 0 deletions
diff --git a/source4/client/client.c b/source4/client/client.c index a8d22e75b7..6cad6a9d39 100644 --- a/source4/client/client.c +++ b/source4/client/client.c @@ -1817,6 +1817,9 @@ static int cmd_fsinfo(const char **cmd_ptr) (unsigned long long) fsinfo.objectid_information.out.unknown[5], (unsigned long long) fsinfo.objectid_information.out.unknown[6] ); break; + case RAW_QFS_GENERIC: + d_printf("\twrong level returned\n"); + break; } done: diff --git a/source4/libcli/raw/rawsetfileinfo.c b/source4/libcli/raw/rawsetfileinfo.c index 7934171ab0..5e780757e8 100644 --- a/source4/libcli/raw/rawsetfileinfo.c +++ b/source4/libcli/raw/rawsetfileinfo.c @@ -124,6 +124,18 @@ static BOOL smb_raw_setinfo_backend(struct smbcli_tree *tree, NEED_BLOB(4); SIVAL(blob->data, 0, parms->mode_information.in.mode); return True; + + /* Unhandled levels */ + + case RAW_SFILEINFO_UNIX_LINK: + case RAW_SFILEINFO_UNIX_HLINK: + case RAW_SFILEINFO_1023: + case RAW_SFILEINFO_1025: + case RAW_SFILEINFO_1029: + case RAW_SFILEINFO_1032: + case RAW_SFILEINFO_1039: + case RAW_SFILEINFO_1040: + break; } return False; diff --git a/source4/torture/gentest.c b/source4/torture/gentest.c index 8a2bba8497..6ce0eb543a 100644 --- a/source4/torture/gentest.c +++ b/source4/torture/gentest.c @@ -1600,6 +1600,14 @@ static BOOL cmp_fileinfo(int instance, CHECK_EQUAL(attribute_tag_information.out.attrib); CHECK_EQUAL(attribute_tag_information.out.reparse_tag); break; + + /* Unhandled levels */ + + case RAW_FILEINFO_SEC_DESC: + case RAW_FILEINFO_EA_LIST: + case RAW_FILEINFO_UNIX_BASIC: + case RAW_FILEINFO_UNIX_LINK: + break; } return True; diff --git a/source4/torture/rpc/samsync.c b/source4/torture/rpc/samsync.c index 9cd30ef019..93bfb71325 100644 --- a/source4/torture/rpc/samsync.c +++ b/source4/torture/rpc/samsync.c @@ -1174,6 +1174,23 @@ static BOOL test_DatabaseSync(struct samsync_state *samsync_state, ret = False; } break; + case NETR_DELTA_DELETE_GROUP: + case NETR_DELTA_RENAME_GROUP: + case NETR_DELTA_DELETE_USER: + case NETR_DELTA_RENAME_USER: + case NETR_DELTA_GROUP_MEMBER: + case NETR_DELTA_DELETE_ALIAS: + case NETR_DELTA_RENAME_ALIAS: + case NETR_DELTA_ALIAS_MEMBER: + case NETR_DELTA_DELETE_TRUST: + case NETR_DELTA_DELETE_ACCOUNT: + case NETR_DELTA_DELETE_SECRET: + case NETR_DELTA_DELETE_GROUP2: + case NETR_DELTA_DELETE_USER2: + case NETR_DELTA_MODIFY_COUNT: + printf("Unhandled delta type %d\n", r.out.delta_enum_array->delta_enum[d].delta_type); + ret = False; + break; } talloc_free(delta_ctx); } diff --git a/source4/winbind/wb_samba3_protocol.c b/source4/winbind/wb_samba3_protocol.c index f9eb7a09d4..479920bf97 100644 --- a/source4/winbind/wb_samba3_protocol.c +++ b/source4/winbind/wb_samba3_protocol.c @@ -118,6 +118,49 @@ NTSTATUS wbsrv_samba3_handle_call(struct wbsrv_call *call) case WINBINDD_LIST_TRUSTDOM: return wbsrv_samba3_list_trustdom(s3call); + + /* Unimplemented commands */ + + case WINBINDD_GETPWNAM: + case WINBINDD_GETPWUID: + case WINBINDD_GETGRNAM: + case WINBINDD_GETGRGID: + case WINBINDD_GETGROUPS: + case WINBINDD_SETPWENT: + case WINBINDD_ENDPWENT: + case WINBINDD_GETPWENT: + case WINBINDD_SETGRENT: + case WINBINDD_ENDGRENT: + case WINBINDD_GETGRENT: + case WINBINDD_PAM_CHAUTHTOK: + case WINBINDD_LIST_USERS: + case WINBINDD_LIST_GROUPS: + case WINBINDD_SID_TO_UID: + case WINBINDD_SID_TO_GID: + case WINBINDD_UID_TO_SID: + case WINBINDD_GID_TO_SID: + case WINBINDD_ALLOCATE_RID: + case WINBINDD_ALLOCATE_RID_AND_GID: + case WINBINDD_CHECK_MACHACC: + case WINBINDD_DOMAIN_INFO: + case WINBINDD_SHOW_SEQUENCE: + case WINBINDD_WINS_BYIP: + case WINBINDD_WINS_BYNAME: + case WINBINDD_GETGRLST: + case WINBINDD_INIT_CONNECTION: + case WINBINDD_DUAL_SID2UID: + case WINBINDD_DUAL_SID2GID: + case WINBINDD_DUAL_IDMAPSET: + case WINBINDD_DUAL_UID2NAME: + case WINBINDD_DUAL_NAME2UID: + case WINBINDD_DUAL_GID2NAME: + case WINBINDD_DUAL_NAME2GID: + case WINBINDD_DUAL_USERINFO: + case WINBINDD_DUAL_GETSIDALIASES: + case WINBINDD_NUM_CMDS: + DEBUG(10, ("Unimplemented winbind samba3 request %d\n", + s3call->request.cmd)); + break; } s3call->response.result = WINBINDD_ERROR; |