summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2003-11-30 19:40:57 +0000
committerJeremy Allison <jra@samba.org>2003-11-30 19:40:57 +0000
commit2ad1159990f5f1be37af12d36b35def37d69ab25 (patch)
tree8bca0e7629b2856417a709667543f23581c6f80d
parent3dda7cf2caf8d39b37d51165f8afdf0ae711bede (diff)
downloadsamba-2ad1159990f5f1be37af12d36b35def37d69ab25.tar.gz
samba-2ad1159990f5f1be37af12d36b35def37d69ab25.tar.bz2
samba-2ad1159990f5f1be37af12d36b35def37d69ab25.zip
Fix signing bug with secondary client trans requests. Turns out the last
packet is the one that matters for checking the signing replies. Need to check the server code does this correctly too.... Bug #832 reported by Volker. Jeremy. (This used to be commit 6750dc33b46c422582176b704592d9b2f1fb04d7)
-rw-r--r--source3/libsmb/clitrans.c20
1 files changed, 20 insertions, 0 deletions
diff --git a/source3/libsmb/clitrans.c b/source3/libsmb/clitrans.c
index 92c1cc99ee..3eb7fcc216 100644
--- a/source3/libsmb/clitrans.c
+++ b/source3/libsmb/clitrans.c
@@ -134,6 +134,16 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
* the primary. Important in signing. JRA. */
cli->mid = mid;
+ /*
+ * Turns out that we need to increment the
+ * sequence number for each packet until the
+ * last one in the signing sequence. That's
+ * the one that matters to check signing replies. JRA.
+ */
+
+ cli_signing_trans_stop(cli);
+ cli_signing_trans_start(cli);
+
show_msg(cli->outbuf);
if (!cli_send_smb(cli)) {
cli_signing_trans_stop(cli);
@@ -427,6 +437,16 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
* the primary. Important in signing. JRA. */
cli->mid = mid;
+ /*
+ * Turns out that we need to increment the
+ * sequence number for each packet until the
+ * last one in the signing sequence. That's
+ * the one that matters to check signing replies. JRA.
+ */
+
+ cli_signing_trans_stop(cli);
+ cli_signing_trans_start(cli);
+
show_msg(cli->outbuf);
if (!cli_send_smb(cli)) {