summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthieu Patou <mat@matws.net>2012-10-13 01:36:06 -0700
committerKai Blin <kai@samba.org>2012-10-13 12:37:53 +0200
commit2c3a8081ea2fd7eaa2d7bacffc35e05555a58c54 (patch)
treecc7860623b258195fb797e49a4b94755858d2a10
parentbddd1182ea44875f28e12cf15fd07a86f43d8716 (diff)
downloadsamba-2c3a8081ea2fd7eaa2d7bacffc35e05555a58c54.tar.gz
samba-2c3a8081ea2fd7eaa2d7bacffc35e05555a58c54.tar.bz2
samba-2c3a8081ea2fd7eaa2d7bacffc35e05555a58c54.zip
s4-dns: Fix the comments about ignoring zones in internal server
Acked-By: Kai Blin <kai@samba.org> Autobuild-User(master): Kai Blin <kai@samba.org> Autobuild-Date(master): Sat Oct 13 12:37:53 CEST 2012 on sn-devel-104
-rw-r--r--source4/dns_server/dns_server.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/source4/dns_server/dns_server.c b/source4/dns_server/dns_server.c
index d139eb7e91..8e2539664c 100644
--- a/source4/dns_server/dns_server.c
+++ b/source4/dns_server/dns_server.c
@@ -832,7 +832,13 @@ static void dns_task_init(struct task_server *task)
z->name = ldb_msg_find_attr_as_string(res->msgs[i], "name", NULL);
z->dn = talloc_move(z, &res->msgs[i]->dn);
- /* Ignore the RootDNSServers zone and zones that we don't support yet */
+ /*
+ * Ignore the RootDNSServers zone and zones that we don't support yet
+ * RootDNSServers should never be returned (Windows DNS server don't)
+ * ..TrustAnchors should never be returned as is, (Windows returns
+ * TrustAnchors) and for the moment we don't support DNSSEC so we'd better
+ * not return this zone.
+ */
if ((strcmp(z->name, "RootDNSServers") == 0) ||
(strcmp(z->name, "..TrustAnchors") == 0)) {
DEBUG(10, ("Ignoring zone %s\n", z->name));