summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-12-16 12:01:51 +1100
committerAndrew Tridgell <tridge@samba.org>2010-01-02 08:16:48 +1100
commit3199e02884af3b14348a88e8d8d7bc852212536f (patch)
tree67f2f5d1432135ed949cc3298a95263546d1e358
parentc071af337ae0ff11104ca07ea81a7ffa7a8405bc (diff)
downloadsamba-3199e02884af3b14348a88e8d8d7bc852212536f.tar.gz
samba-3199e02884af3b14348a88e8d8d7bc852212536f.tar.bz2
samba-3199e02884af3b14348a88e8d8d7bc852212536f.zip
s4-dsdb: add a comment on the use of ldb_rename()
We need to use ldb_rename() and not dsdb_module_rename() here as we need the rename to be processed by the current module
-rw-r--r--source4/dsdb/samdb/ldb_modules/repl_meta_data.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 7488a1bee9..dadaf32f80 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -2078,6 +2078,9 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
ldb_debug(ldb, LDB_DEBUG_TRACE, "replmd_replicated_request rename %s => %s\n",
ldb_dn_get_linearized(ar->search_msg->dn),
ldb_dn_get_linearized(msg->dn));
+ /* we can't use dsdb_module_rename() here as we need
+ the rename call to be intercepted by this module, to
+ allow it to process linked attribute changes */
if (ldb_rename(ldb, ar->search_msg->dn, msg->dn) != LDB_SUCCESS) {
ldb_debug(ldb, LDB_DEBUG_FATAL, "replmd_replicated_request rename %s => %s failed - %s\n",
ldb_dn_get_linearized(ar->search_msg->dn),